-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unix socket transport #60
base: master
Are you sure you want to change the base?
Conversation
@h2o2-stripe could you give some more context around the need to use a unix socket? Most other providers I'm aware of or use don't have this functionality, so this seems like an interesting request |
@jamestoyer, thanks for the response! We use an HTTP proxy that runs on developer laptops that allows command line tools to access internal sites that require client certificates. In particular, it exposes a Unix domain socket that acts as an HTTP proxy. Plain HTTP requests to this proxy will be forwarded over HTTPS using the user's client certificate. |
That's certainly not a use case I've heard of or seen before. How are you getting around this for other providers? Or do you not use them locally? |
Most of our other providers either: |
@h2o2-stripe Have you tried using the HTTP_PROXY env variable?
From: https://golang.org/pkg/net/http/ It feels like this is the more correct solution. If it doesn't work, we can try and fix that instead |
The more I think about his PR the more I believe it's not something that should exist in this provider for two reasons.
|
…ad-function Set name property in resourceXrayPolicyRead
The intention was to allow to use unix socket as transport.
In our case a proxy service opens unix socket and adds certificates and credentials on the way to Artifactory.